Comments on: Scal v0.2 Pre-release. Comments please.

By: jamiegrove

jamiegrove — Wed, 21 Nov 2007 00:46:28 +0000

Version 0.2 is now available at:

http://scal.fieldguidetoprogrammers.com

By: IanTyndall

IanTyndall — Tue, 13 Nov 2007 14:34:58 +0000

Pug,
I’ve added unit tests to my branch for this, thx!

By: Pug

Pug — Tue, 13 Nov 2007 14:15:06 +0000

Hi, jamiegrove.
checked out svn and problem solved. Thank you very much for your quick help an keep up the good work.

Greets

By: jamiegrove

jamiegrove — Tue, 13 Nov 2007 12:53:06 +0000

Hi, Pug.

I didn’t realize that bug was still in v0.2. Looks like I’ve got another unittest to add!

The problem is in line 66 (and line 67 too for day). I’ve made a few adjustments and uploaded the corrected code to svn, and the demo on this site. The ZIP archive also reflects this change.

Thanks!

By: Pug

Pug — Tue, 13 Nov 2007 11:52:49 +0000

Thanks for your quick reply.
Sorry I forgot to mention the version.
I downloaded the v0.2 zip. I also tried the svn version.
My line 154 reads completely different, like this:

var buildWeek = function(day) {

Greets

By: jamiegrove

jamiegrove — Mon, 12 Nov 2007 23:16:00 +0000

Hi Pug.

Yep. That is a bug in v0.1. If you change line 154 to read:

if (month != 0 || day != 1){

instead of:

if (month != 0 && day != 1){

Your set will work correctly. I am going to update this on the live site.

By: Pug

Pug — Mon, 12 Nov 2007 22:56:23 +0000

I try to build a calendar for January with this line :

cal1 = new scal(‘calender1′,update1,{year:2007,month:1,day:3,titleformat:’mmmm yyyy’,closebutton:’X',dayheadlength:2});

But I always get a calender for November (2007). If I browse through the months there is January displayed correctly, but I can’t instantiate with January.
Can you help me ?

Greets

By: jamiegrove

jamiegrove — Sat, 03 Nov 2007 01:39:44 +0000

Got it. Trunk is updated. (scal.js and scaltester_new.html)

        $A(Date.prototype.daynames.sortBy(function(s,i){
				i+=this.options.weekdaystart;
				if(i>6){i-=7;}
				return i;
			}.bind(this))).each(function(day,i) {
         	var cell = new Element('div',{'class':'cal_day_name_'+ i});
			cell.addClassName('daybox').addClassName('dayboxname').
update(day.substr(0,this.options.dayheadlength));
            if(i == 6) { cell.addClassName('endweek'); }
			weekbox.insert(cell);
        }.bind(this));

By: jamiegrove

jamiegrove — Sat, 03 Nov 2007 00:36:49 +0000

I’ve made a small change to scaltester_new.html, moving the builder panels below the scal instance. I didn’t notice this on my laptop (which is widescreen) but at 1024×468 there was some nasty overlap. You can see this live at:

http://www.fieldguidetoprogrammers.com/versions/scal_0.2/

Also, I noticed a bug with the weekday start option. The buildhead function does not take the week start day into account. I’m going to mess with it a bit and see if I can fix it.

By: jamiegrove

jamiegrove — Fri, 02 Nov 2007 19:07:19 +0000

Hi guys. I’ve merged the js changes from Ian’s branch into the trunk.